Add SHTC3_v2 usermod to platformio.ini by Will-wastelander · Pull Request #5756 · wled/WLED

Will-wastelander · 2026-07-26T19:44:05Z

Add SHTC3_v2 usermod for temperature sensing.

Summary by CodeRabbit

New Features
- Added support for SHTC3 v2 temperature and humidity sensors to the Waveshare ESP32-S3 Hub75 build.
- Enables temperature and humidity readings from compatible SHTC3 v2 devices.

Add SHTC3_v2 usermod for temperature sensing.

coderabbitai · 2026-07-26T19:44:22Z

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

@coderabbitai resume to resume automatic reviews.
@coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

▶️ Resume reviews
🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 988db8a9-4a45-4006-9015-eac1a598aa7b

📥 Commits

Reviewing files that changed from the base of the PR and between 1495fd7 and 89e3284.

📒 Files selected for processing (1)

platformio.ini

🚧 Files skipped from review as they are similar to previous changes (1)

platformio.ini

Included review availability: Your plan includes up to 10 reviews per rolling hour; 9 remain after this review.

Walkthrough

The Waveshare ESP32-S3 32MB HUB75 build environment adds the pinned SHTC3_v2 usermod repository to its existing custom usermod list.

Changes

SHTC3 usermod integration

Layer / File(s)	Summary
Add SHTC3_v2 to build environment `platformio.ini`	The `waveshare_esp32s3_32MB_hub75` environment now includes the pinned `SHTC3_v2` Git repository in `custom_usermods`.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 89e32

This PR adds the SHTC3_v2 usermod configuration, with no actionable merge-blocking risk remaining beyond normal checks and review.

Possibly related PRs

wled/WLED#4592: Updates custom_usermods in platformio.ini; a related CI matrix consumes this configuration.
wled/WLED#5644: Introduces the custom_usermods configuration approach extended by this change.

Suggested reviewers: netmindz, willmmiles

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the addition of the SHTC3_v2 usermod to platformio.ini.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

coderabbitai

🧹 Nitpick comments (1)

platformio.ini (1)
1168-1168: 🔒 Security & Privacy | 🔵 Trivial | ⚡ Quick win

Pin the SHTC3_v2 dependency to an immutable commit.

The new external usermod tracks the repository’s moving default branch, so future builds may silently consume different code. Pin it to a commit SHA, consistent with the nearby audioreactive dependency.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@platformio.ini` at line 1168, Update the SHTC3_v2 dependency declaration to
reference a specific immutable commit SHA instead of the repository’s moving
default branch, following the nearby audioreactive dependency’s pinning format.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@platformio.ini`:
- Line 1168: Update the SHTC3_v2 dependency declaration to reference a specific
immutable commit SHA instead of the repository’s moving default branch,
following the nearby audioreactive dependency’s pinning format.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 3ca38a03-d879-4669-b14d-9d652194e67a

📥 Commits

Reviewing files that changed from the base of the PR and between 8db3d7a and e39e1ab.

📒 Files selected for processing (1)

platformio.ini

Updated SHTC3_v2 usermod URL to specific commit.

Will-wastelander

Updated waveshare_esp32s3_32MB_hub75 build env to include SHTC3 UM, enabling the onboard temp/hum sensor.

Will-wastelander · 2026-07-26T23:15:47Z

@softhack007 They created this UM at my request, in #sensors on discord. I'm not sure if they have released it to WLED-AC yet or not, but I wanted to get this added to the build env, so it would have the support. Here is the link to their post in that channel.
https://discord.com/channels/473448917040758787/708677213830250527/1527357353056534579

softhack007 · 2026-07-27T09:52:38Z

@lost-hope I've quickly looked through the UM code.

One line is a bit problematic

https://github.com/lost-hope/SHTC3_v2/blob/b8a648e7b71ac1bb6efca1bacdf6577aeb17b09c/SHTC3_v2.cpp#L134

this delay() runs in the main loop, it can lead to effect stuttering for higher framerates, especially above 60FPS.

DedeHai · 2026-07-29T14:55:41Z

a delay of 15ms is really bad, it should be a state machine instead. i.e. use timestamps and states, if its not time to read yet, just give the CPU back to other tasks.

lost-hope · 2026-07-29T17:45:08Z

@softhack007 @DedeHai it became a state machine now ;D ( made it before i saw your comment)
so the 16ms ( there was another delay of 1ms a few lines up) are gone now.
When you two are happy with it now, i will add it to the list in the kb.

Updated SHTC3_v2 usermod link to the latest commit.

DedeHai · 2026-07-29T18:47:42Z

When you two are happy with it now, i will add it to the list in the kb.

looks good, go ahead :)

lost-hope

Why are you referencing to a specific commit?

Will-wastelander · 2026-07-29T19:59:16Z

Why are you referencing to a specific commit?

@lost-hope Coderabbitai nitpick.. If it's not needed, then I can change it to main. I have 0 issues w/ that. That's what I originally had. But Coderabbitat complained.

#5756 (review)

willmmiles

Commit pinning is a must - otherwise we have no guarantees on what's getting built, opening us up to supply chain attacks.

Will-wastelander · 2026-07-29T23:12:11Z

Commit pinning is a must - otherwise we have no guarantees on what's getting built, opening us up to supply chain attacks.

@willmmiles That's what I was figuring, and other that coderabbitai nitpicking it, figured would be best. I have tested this commit, and know it works.

Add SHTC3_v2 usermod to platformio.ini

e39e1ab

Add SHTC3_v2 usermod for temperature sensing.

coderabbitai Bot reviewed Jul 26, 2026

View reviewed changes

Change SHTC3_v2 URL to point to a specific commit

4812bb0

Updated SHTC3_v2 usermod URL to specific commit.

Will-wastelander commented Jul 26, 2026

View reviewed changes

softhack007 reviewed Jul 26, 2026

View reviewed changes

Comment thread platformio.ini Outdated

softhack007 requested review from lost-hope and netmindz July 26, 2026 23:09

Merge branch 'main' into patch-1

ecd56e6

lost-hope approved these changes Jul 29, 2026

View reviewed changes

Will-wastelander added 2 commits July 29, 2026 11:36

Update SHTC3_v2 usermod link

6a5bbe7

Updated SHTC3_v2 usermod link to the latest commit.

Merge branch 'main' into patch-1

b5e2cc9

lost-hope reviewed Jul 29, 2026

View reviewed changes

willmmiles approved these changes Jul 29, 2026

View reviewed changes

Will-wastelander added 2 commits August 9, 2026 07:52

Merge branch 'main' into patch-1

1495fd7

Merge branch 'main' into patch-1

89e3284

Uh oh!

Uh oh!

Conversation

Will-wastelander commented Jul 26, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jul 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviews paused

Walkthrough

Changes

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Will-wastelander left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Will-wastelander commented Jul 26, 2026

Uh oh!

softhack007 commented Jul 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DedeHai commented Jul 29, 2026

Uh oh!

lost-hope commented Jul 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DedeHai commented Jul 29, 2026

Uh oh!

lost-hope left a comment

Choose a reason for hiding this comment

Uh oh!

Will-wastelander commented Jul 29, 2026

Uh oh!

willmmiles left a comment

Choose a reason for hiding this comment

Uh oh!

Will-wastelander commented Jul 29, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Will-wastelander commented Jul 26, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jul 26, 2026 •

edited

Loading

softhack007 commented Jul 27, 2026 •

edited

Loading

lost-hope commented Jul 29, 2026 •

edited

Loading